Fix parentStyle must not be null
#923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #831
Fix
When we reverted this here #882, we unintentionally also removed the fix in #832, because it was stack-added on purpose as explained in this conversation (we could only get to properly test the conditions for #834 with monkeys when that patch was first in place).
This PR just cherry-picks the original commit to restore things.
Copying from the original PR #832:
Test
No testing needed, but you can run the monkeys to verify (could follow the steps provided in #834)
Make sure strings will be translated:
strings.xmlas a part of the integration PR.